Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Assert (with error message) for timestamp range #168

Merged
merged 6 commits into from
Aug 7, 2019
Merged

Better Assert (with error message) for timestamp range #168

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0696e1
Better Assert (with error message) for timestampt range
Jul 30, 2019
67de537
Merge branch 'master' into betterErrorMessageForFlackyTest
Jul 30, 2019
54f7c53
Merge branch 'master' into betterErrorMessageForFlackyTest
Jul 30, 2019
6edcb85
Merge branch 'master' into betterErrorMessageForFlackyTest
austinlparker Aug 7, 2019
9379918
Merge branch 'master' into betterErrorMessageForFlackyTest
Aug 7, 2019
8d62a4b
Merge branch 'master' into betterErrorMessageForFlackyTest
Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/OpenTelemetry.Tests/Impl/Trace/SpanTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,8 +699,7 @@ public void Dispose()
private void AssertApproxSameTimestamp(DateTime one, DateTime two)
{
var timeShift = Math.Abs((one - two).TotalMilliseconds);
Assert.True(timeShift > 0);
Assert.True(timeShift < 10);
Assert.InRange(timeShift, double.Epsilon, 10);
}
}
}