Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make oltp exporter class and constructor public #1653

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Dec 10, 2020

Fixes #.

Changes

Please provide a brief description of the changes here.
Making oltp exporter class and constructor public: This is needed in order to allow use of Filtering Processor

This change is a part of following issue
1612
For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar requested a review from a team December 10, 2020 19:56
@vishweshbankwar vishweshbankwar marked this pull request as draft December 10, 2020 19:58
@vishweshbankwar vishweshbankwar changed the title Made oltp class and constructor public Make oltp class and constructor public Dec 10, 2020
@vishweshbankwar vishweshbankwar changed the title Make oltp class and constructor public Make oltp exporter class and constructor public Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #1653 (ed0ef0e) into master (8cda9ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         245      245           
  Lines        6605     6607    +2     
=======================================
+ Hits         5405     5407    +2     
  Misses       1200     1200           
Impacted Files Coverage Δ
...try.Exporter.OpenTelemetryProtocol/OtlpExporter.cs 55.81% <100.00%> (+2.15%) ⬆️

@vishweshbankwar vishweshbankwar marked this pull request as ready for review December 10, 2020 21:26
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 94c2755 into open-telemetry:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants