Filter() description and code snippet clarity and consistency #1628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reword the description and code snippets for
Filter()
in OpenTelemetry.Instrumentation.* READMEs.Grammar and code syntax updated to be consistent between AspNet, AspNetCore, and Http.
Where components were inconsistent, the following decisions were made. These can easily be changed if desired.
()
for single params eg.(x) => {}
options
instead ofopt
{}
eg.(x) => x.foo()
instead of(x) => { x.foo(); }
Issue driving change: #1186
Previous related PRs: #1615
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes