Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter spec fixup 2 #1620

Merged
merged 6 commits into from
Nov 28, 2020
Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Nov 25, 2020

Changes

Should match up to open-telemetry/opentelemetry-specification#1257 when merged.

TODOs

  • CHANGELOG.md updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team November 25, 2020 00:36
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1620 (77334ae) into master (fe9e90d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
+ Coverage   81.79%   81.83%   +0.04%     
==========================================
  Files         245      245              
  Lines        6575     6579       +4     
==========================================
+ Hits         5378     5384       +6     
+ Misses       1197     1195       -2     
Impacted Files Coverage Δ
...Telemetry.Api/Internal/ActivityHelperExtensions.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Api/Internal/StatusHelper.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 94.11% <100.00%> (ø)
....Jaeger/Implementation/JaegerActivityExtensions.cs 95.62% <100.00%> (+0.06%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 86.84% <100.00%> (ø)
...plementation/ZipkinActivityConversionExtensions.cs 98.78% <100.00%> (+0.03%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok to me... urm, i mean OK

@cijothomas cijothomas merged commit 1bab62c into open-telemetry:master Nov 28, 2020
@CodeBlanch CodeBlanch deleted the exporter-spec2 branch November 30, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants