Add Azure collector #161
Add Azure collector #161
Conversation
src/OpenTelemetry.Collector.Azure/OpenTelemetry.Collector.Azure.csproj
Outdated
Show resolved
Hide resolved
pakrym
force-pushed
the
pakrym/azure-collector
branch
from
f49ebe8 to
936e674
Compare
pakrym
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
src/OpenTelemetry.Collector.Dependencies/AzureSdkDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
| { { "HttpHandlerDiagnosticListener", (t, s) => new HttpHandlerDiagnosticListener(t, s) } }, | ||
| { | ||
| { "HttpHandlerDiagnosticListener", (t, s) => new HttpHandlerDiagnosticListener(t, s) }, | ||
| { "Azure.Clients", (t, s) => new AzureSdkDiagnosticListener("Azure.Clients", t, sampler) }, |
There was a problem hiding this comment.
s is not necessarily the same as sampler - sampler could be null and this crazy lambda underneath falls back to something. So please use s
There was a problem hiding this comment.
s is lambda that takes HttpRequestMessage, what do I pass into it?
There was a problem hiding this comment.
no I mean this lambda:
x =>
{
ISampler s = null;
try
{
s = options.CustomSampler(x);
}
catch (Exception e)
{
s = null;
DependenciesCollectorEventSource.Log.ExceptionInCustomSampler(e);
}
return s ?? sampler;
});I.e. "Azure.Clients", (t, s) => new AzureSdkDiagnosticListener("Azure.Clients", t, sampler) -> "Azure.Clients", (t, s) => new AzureSdkDiagnosticListener("Azure.Clients", t, s)
There was a problem hiding this comment.
Right, type of s is Func<HttpRequestMessage, ISampler> how do I use it in my listener to get a sampler? Always pass null in?
There was a problem hiding this comment.
oh, I see. sorry. let me think for a moment
|
|
||
| var span = this.tracer.SpanBuilder(operationName) | ||
| .SetCreateChild(false) | ||
| .SetSpanKind(SpanKind.Client) |
There was a problem hiding this comment.
oh, by the way, this is not always right
- http spans should have kind = client
- convenience layer spans should have kind = internal
This is important for Azure Monitor and maybe other backends for better user experience.
No description provided.