Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otlp exporter options #1587

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Otlp exporter options #1587

merged 4 commits into from
Nov 19, 2020

Conversation

Austin-Tan
Copy link
Member

@Austin-Tan Austin-Tan commented Nov 19, 2020

Fixes #1494 .

Following closely the recent PRs #1584 and #1504 , just applying also to the Otlp Exporter.

Will update the ReadMes for the new BatchExporterOptions for all three exporters in a separate PR.

Changes

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Austin-Tan Austin-Tan requested a review from a team November 19, 2020 03:09
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1587 (d7798c7) into master (b710c31) will decrease coverage by 0.09%.
The diff coverage is 55.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   80.74%   80.64%   -0.10%     
==========================================
  Files         242      242              
  Lines        6544     6562      +18     
==========================================
+ Hits         5284     5292       +8     
- Misses       1260     1270      +10     
Impacted Files Coverage Δ
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 15.38% <0.00%> (-17.95%) ⬇️
...nTelemetryProtocol/OtlpExporterHelperExtensions.cs 92.30% <87.50%> (-7.70%) ⬇️
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <100.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️

@cijothomas cijothomas merged commit e17b459 into open-telemetry:master Nov 19, 2020
@Austin-Tan Austin-Tan deleted the OtlpExporterOptions branch November 19, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OtlpExporter to expose settings to control ExportingProcessor
3 participants