Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding service.namespace as tags for zipkin #1521

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Adding service.namespace as tags for zipkin #1521

merged 2 commits into from
Nov 12, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #1511.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

Sorry, something went wrong.

@eddynaka eddynaka self-assigned this Nov 12, 2020
@eddynaka eddynaka marked this pull request as ready for review November 12, 2020 12:37
@eddynaka eddynaka requested a review from a team November 12, 2020 12:37
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1521 (407047a) into master (cb7f421) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
+ Coverage   81.27%   81.30%   +0.02%     
==========================================
  Files         232      232              
  Lines        6311     6305       -6     
==========================================
- Hits         5129     5126       -3     
+ Misses       1182     1179       -3     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.04% <100.00%> (+1.30%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

updating changelog

updating changelog

updating changelog

Revert "Adding service.namespace as tags for zipkin"

This reverts commit 1868e71b964fa030bc33ece441047b19fa221688.

updating file and changelog

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to work on more targeted unit tests as a followup.

@cijothomas cijothomas merged commit d1c174d into open-telemetry:master Nov 12, 2020
@eddynaka eddynaka deleted the feature/adding-service-namespace-tags branch November 12, 2020 19:03
@@ -119,9 +118,6 @@ internal void SetLocalEndpointFromResource(Resource resource)
case Resource.ServiceNameKey:
serviceName = label.Value as string;
continue;
case Resource.ServiceNamespaceKey:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddynaka FYI same logic exists in JaegerExporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zipkin Exporter send service.namespace as Zipkin tag
3 participants