-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TracerProvider Shutdown #1489
Merged
cijothomas
merged 18 commits into
open-telemetry:master
from
utpilla:utpilla/Add-TracerProviderSdk-Shutdown
Nov 13, 2020
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e4cd13a
Add Shutdown method to TracerProvider
utpilla 6823411
Updated CHANGELOG.md
utpilla 373e7d6
Updated the PublicAPI.Unshipped txt files to include the TracerProvid…
utpilla 8a80ddb
Updated the OnShutdown method to move listener dispose after processo…
utpilla e171c4e
Resolving merge conflicts
utpilla d82e177
Fixed build issues
utpilla 6e30f74
Resolving merge conflicts
utpilla 731f202
Merge remote-tracking branch 'origin/master' into utpilla/Add-TracerP…
utpilla aab26cd
Merge branch 'master' into utpilla/Add-TracerProviderSdk-Shutdown
cijothomas 624ae10
Merge remote-tracking branch 'origin/master' into utpilla/Add-TracerP…
utpilla 61d4e01
Address PR changes
utpilla a0292f2
Merge remote-tracking branch 'fork/utpilla/Add-TracerProviderSdk-Shut…
utpilla b84c97f
Merge branch 'master' into utpilla/Add-TracerProviderSdk-Shutdown
cijothomas 7061414
Added Instrumentations Dispoe to TracerProviderSdk OnShutdown method
utpilla 4aeaf1c
Merge branch 'utpilla/Add-TracerProviderSdk-Shutdown' of https://gith…
utpilla c001606
Merging with master
utpilla f508290
Merge branch 'master' into utpilla/Add-TracerProviderSdk-Shutdown
cijothomas 134d4da
Merge branch 'master' into utpilla/Add-TracerProviderSdk-Shutdown
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not dispose the instrumentations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec just says that any calls to TracerPorvider after Shutdown should result in a no-op. It also explicitly says to call shutdown of each of the processors. We can achieve this by only disposing the listener and calling the CompositeProcessor Shutdown. I didn't dispose instrumentation to keep the Shutdown functionality as minimum as possible and in accordance with the spec.
We could Dispose the instrumentations too and then TracerProviderSdk Shutdown will be functionally pretty close to TracerProviderSdk Dispose with only Sampler and the base TracerProvider not getting disposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec just says at least processors must be shutdown.
i think shutdown should do same as dispose.