Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelfDiagnosticsModule] Add user guide for troubleshooting #1477

Merged

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Nov 5, 2020

Provide user guide to enable self diagnostics module for troubleshooting for #1258.

Changes

Add troubleshooting doc to enable self diagnostics module

Question: I'm not sure if this is the right place to add the guide. Any suggestion for a better spot?

src/OpenTelemetry/README.md Outdated Show resolved Hide resolved
src/OpenTelemetry/README.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiang17
Copy link
Contributor Author

xiang17 commented Nov 5, 2020

Updated configuration file name to OTEL_DIAGNOSTICS.json per discussion in #1468 (comment).

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1477 (6f9537f) into master (b956a5f) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
+ Coverage   81.19%   81.20%   +0.01%     
==========================================
  Files         233      233              
  Lines        6311     6311              
==========================================
+ Hits         5124     5125       +1     
+ Misses       1187     1186       -1     
Impacted Files Coverage Δ
...nTelemetry/Internal/SelfDiagnosticsConfigParser.cs 53.65% <75.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️

src/OpenTelemetry/README.md Outdated Show resolved Hide resolved
@cijothomas cijothomas merged commit 32a500c into open-telemetry:master Nov 9, 2020
@xiang17 xiang17 deleted the xiang17/self-diagnostics-doc branch November 10, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants