Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation Library doc #1467

Merged

Conversation

cijothomas
Copy link
Member

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@@ -60,7 +60,103 @@ Exporter to the `TracerProvider` as shown in the example [here](./Program.cs).

## Instrumentation Library

TBD
The goal of the OpenTelemetry project is to make every library and application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's the official goal of OpenTelemetry, might be helpful to put a link here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both apps and libs are not calling the OpenTelemetry API - who is going to call it? 😄

@cijothomas cijothomas changed the title (WIP) Instrumentation doc Instrumentation Library doc Nov 11, 2020
@cijothomas cijothomas marked this pull request as ready for review November 11, 2020 01:21
@cijothomas cijothomas requested a review from a team November 11, 2020 01:21
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit baa2972 into open-telemetry:master Nov 11, 2020
@cijothomas cijothomas deleted the cijothomas/instrumentationdoc1 branch November 11, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants