-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vibankwa/aspnet enrich documentation #1465
vibankwa/aspnet enrich documentation #1465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Having just updated the info on the Enrich option for HttpClient instrumentation in #1244, I noted that the AspNetCore instrumentation doc contains the following verbiage:
I copied this text for consistency. Maybe the same makes sense for this doc as well. |
….com/vishweshbankwar/opentelemetry-dotnet into vibankwa/aspnet-enrich-documentation
@alanwest Thanks for the feedback. I added that section. Please review. |
Fixes #.
Adding Enrich example in Readme for AspNet instrumentation.
Issue #1450
Removing the older example of Enriching the activity in AspNet from Readme.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes