Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vibankwa/aspnet enrich documentation #1465

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 5, 2020

Fixes #.

  1. Adding Enrich example in Readme for AspNet instrumentation.
    Issue #1450

  2. Removing the older example of Enriching the activity in AspNet from Readme.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2020

CLA Check
The committers are authorized under a signed CLA.

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 5, 2020 19:11
@vishweshbankwar vishweshbankwar requested a review from a team November 5, 2020 19:11
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alanwest
Copy link
Member

alanwest commented Nov 5, 2020

Having just updated the info on the Enrich option for HttpClient instrumentation in #1244, I noted that the AspNetCore instrumentation doc contains the following verbiage:

Processor, is the general extensibility point to add additional properties to any activity. The Enrich option is specific to this instrumentation, and is provided to get access to HttpRequest and HttpResponse.

See https://github.com/open-telemetry/opentelemetry-dotnet/blob/master/src/OpenTelemetry.Instrumentation.AspNetCore/README.md#enrich.

I copied this text for consistency. Maybe the same makes sense for this doc as well.

@vishweshbankwar
Copy link
Member Author

@alanwest Thanks for the feedback. I added that section. Please review.

@cijothomas cijothomas merged commit 0cf26d3 into open-telemetry:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants