Remove RandomGenerator again

src/OpenTelemetry/Trace/SpanBuilderOptions.cs

@@ -20,15 +20,12 @@ namespace OpenTelemetry.Trace
 
     internal class SpanBuilderOptions
     {
-        internal SpanBuilderOptions(IRandomGenerator randomGenerator, IStartEndHandler startEndHandler, ITraceConfig traceConfig)
+        internal SpanBuilderOptions(IStartEndHandler startEndHandler, ITraceConfig traceConfig)
         {
-            this.RandomHandler = randomGenerator;
             this.StartEndHandler = startEndHandler;
             this.TraceConfig = traceConfig;
         }
 
-        internal IRandomGenerator RandomHandler { get; }
-
         internal IStartEndHandler StartEndHandler { get; }
 
         internal ITraceConfig TraceConfig { get; }

src/OpenTelemetry/Trace/Tracer.cs

@@ -38,26 +38,24 @@ public sealed class Tracer : ITracer
         /// <summary>
         /// Creates an instance of <see cref="ITracer"/>.
         /// </summary>
-        /// <param name="randomGenerator">Span id generator.</param>
         /// <param name="startEndHandler">Start/end event handler.</param>
         /// <param name="traceConfig">Trace configuration.</param>
-        public Tracer(IRandomGenerator randomGenerator, IStartEndHandler startEndHandler, ITraceConfig traceConfig)
-            : this(randomGenerator, startEndHandler, traceConfig, null, null, null)
+        public Tracer(IStartEndHandler startEndHandler, ITraceConfig traceConfig)
+            : this(startEndHandler, traceConfig, null, null, null)
         {
         }
 
         /// <summary>
         /// Creates an instance of <see cref="ITracer"/>.
         /// </summary>
-        /// <param name="randomGenerator">Span id generator.</param>
         /// <param name="startEndHandler">Start/end event handler.</param>
         /// <param name="traceConfig">Trace configuration.</param>
         /// <param name="spanExporter">Exporter for span.</param>
         /// <param name="binaryFormat">Binary format context propagator.</param>
         /// <param name="textFormat">Text format context propagator.</param>
-        public Tracer(IRandomGenerator randomGenerator, IStartEndHandler startEndHandler, ITraceConfig traceConfig, SpanExporter spanExporter, IBinaryFormat binaryFormat, ITextFormat textFormat)
+        public Tracer(IStartEndHandler startEndHandler, ITraceConfig traceConfig, SpanExporter spanExporter, IBinaryFormat binaryFormat, ITextFormat textFormat)
         {
-            this.spanBuilderOptions = new SpanBuilderOptions(randomGenerator, startEndHandler, traceConfig);
+            this.spanBuilderOptions = new SpanBuilderOptions(startEndHandler, traceConfig);
             this.spanExporter = spanExporter ?? (SpanExporter)SpanExporter.Create(ExporterBufferSize, ExporterScheduleDelay);
             this.BinaryFormat = binaryFormat ?? new BinaryFormat();
             this.TextFormat = textFormat ?? new TraceContextFormat();

src/OpenTelemetry/Trace/Tracing.cs

@@ -32,7 +32,6 @@ public sealed class Tracing
 
         internal Tracing()
         {
-            IRandomGenerator randomHandler = new RandomGenerator();
             IEventQueue eventQueue = new SimpleEventQueue();
 
             TraceConfig = new Config.TraceConfig();
@@ -54,7 +53,7 @@ internal Tracing()
                     ((ExportComponent)ExportComponent).SampledSpanStore,
                     eventQueue);
 
-            tracer = new Tracer(randomHandler, startEndHandler, TraceConfig);
+            tracer = new Tracer(startEndHandler, TraceConfig);
         }
 
         /// <summary>   

test/OpenTelemetry.Collector.AspNetCore.Tests/BasicTests.cs

@@ -48,7 +48,7 @@ public BasicTests(WebApplicationFactory<Startup> factory)
         public async Task SuccesfulTemplateControllerCallGeneratesASpan()
         {
             var startEndHandler = new Mock<IStartEndHandler>();
-            var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig());
+            var tracer = new Tracer(startEndHandler.Object, new TraceConfig());
 
             void ConfigureTestServices(IServiceCollection services) =>
                 services.AddSingleton<ITracer>(tracer);
@@ -104,7 +104,7 @@ public async Task SuccesfulTemplateControllerCallUsesParentContext()
                 Tracestate.Empty
                 ));
 
-            var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig(), null, null, tf.Object);
+            var tracer = new Tracer(startEndHandler.Object, new TraceConfig(), null, null, tf.Object);
 
             // Arrange
             using (var client = this.factory

test/OpenTelemetry.Collector.AspNetCore.Tests/IncomingRequestsCollectionsIsAccordingToTheSpecTests.cs

@@ -55,7 +55,7 @@ public override async Task<bool> ProcessAsync(HttpContext context)
         public async Task SuccesfulTemplateControllerCallGeneratesASpan()
         {
             var startEndHandler = new Mock<IStartEndHandler>();
-            var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig());
+            var tracer = new Tracer(startEndHandler.Object, new TraceConfig());
 
             // Arrange
             using (var client = this.factory

test/OpenTelemetry.Collector.Dependencies.Tests/BasicTests.cs

@@ -60,7 +60,7 @@ public async Task HttpDepenenciesCollectorInjectsHeadersAsync()
                         expectedSpanId = sc.SpanId;
                     });
 
-                var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig(), null, null, tf.Object);
+                var tracer = new Tracer(startEndHandler.Object, new TraceConfig(), null, null, tf.Object);
 
                 using (var dc = new DependenciesCollector(new DependenciesCollectorOptions(), tracer, Samplers.AlwaysSample))
                 {

test/OpenTelemetry.Collector.Dependencies.Tests/HttpClientTests.cs

@@ -99,7 +99,7 @@ public async Task HttpOutCallsAreCollectedSuccesfullyAsync(HttpOutTestCase tc)
                 out var port);
 
             var startEndHandler = new Mock<IStartEndHandler>();
-            var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig());
+            var tracer = new Tracer(startEndHandler.Object, new TraceConfig());
             tc.url = NormaizeValues(tc.url, host, port);
 
             using (serverLifeTime)

test/OpenTelemetry.Collector.StackExchangeRedis.Tests/StackExchangeRedisCallsCollectorTests.cs

@@ -30,7 +30,7 @@ public class StackExchangeRedisCallsCollectorTests
         public async void ProfilerSessionUsesTheSameDefault()
         {
             var startEndHandler = new Mock<IStartEndHandler>();
-            var tracer = new Tracer(new RandomGenerator(), startEndHandler.Object, new TraceConfig());
+            var tracer = new Tracer(startEndHandler.Object, new TraceConfig());
 
             using (var collector = new StackExchangeRedisCallsCollector(tracer, null, null))
             {

test/OpenTelemetry.Tests/Impl/Trace/SpanBuilderTest.cs

@@ -40,7 +40,7 @@ public SpanBuilderTest()
         {
             // MockitoAnnotations.initMocks(this);
             spanBuilderOptions =
-                new SpanBuilderOptions(new RandomGenerator(), startEndHandler, traceConfig);
+                new SpanBuilderOptions(startEndHandler, traceConfig);
             var configMock = Mock.Get<ITraceConfig>(traceConfig);
             configMock.Setup((c) => c.ActiveTraceParams).Returns(alwaysSampleTraceParams);
             // when(traceConfig.getActiveTraceParams()).thenReturn(alwaysSampleTraceParams);

test/OpenTelemetry.Tests/Impl/Trace/TracerTest.cs

@@ -36,7 +36,7 @@ public TracerTest()
         {
             startEndHandler = Mock.Of<IStartEndHandler>();
             traceConfig = Mock.Of<ITraceConfig>();
-            tracer = new Tracer(new RandomGenerator(), startEndHandler, traceConfig);
+            tracer = new Tracer(startEndHandler, traceConfig);
         }
 
         [Fact]