Switch to ActivityTraceId and ActivitySpanId (from .NET) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
lmolkova
changed the title
lmolkova
force-pushed
the
SwitchToActivityTraceIdSpanId
branch
from
4ee86d5 to
3a30835
Compare
lmolkova
changed the title
lmolkova
force-pushed
the
SwitchToActivityTraceIdSpanId
branch
from
6f9684d to
fa4ed40
Compare
|
@SergeyKanzhelev @austinlparker @discostu105 please review. |
Merged
lmolkova
force-pushed
the
SwitchToActivityTraceIdSpanId
branch
from
fa4ed40 to
e755432
Compare
|
@SergeyKanzhelev @austinlparker @discostu105 please review, this is ready |
austinlparker
approved these changes
Jul 11, 2019
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #59 and clean implementation of #128 part 1 (first step to support .NEt activities)
This change removes TraceId, SpanId, traceOptions. TraceOptionsBuilder, IRandomGenerator (and impl) and Array utils.
It uses ActivityTraceId, ActivitySpanId and ActivityTraceFlags from System.Diagnostics.DiagnosticSource instead.
Depends on #133 - do not merge