Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Activity.EnumerateEvents extension #1319

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 3, 2020

Added an extension method for enumerating Activity Events without an allocation. Updated Jaeger & Zipkin to use it. A bit of renaming inside Jaeger & Zipkin to make their usage of enumeration extensions consistent.

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
EnumerateNonemptyActivityEvents 79.39 ns 1.429 ns 2.427 ns 0.0067 - - 56 B
EnumerateEventsNonemptyActivityEvents 46.03 ns 0.502 ns 0.445 ns - - - -

TODOs:

  • CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team October 3, 2020 17:19
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #1319 into master will increase coverage by 0.02%.
The diff coverage is 94.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   78.63%   78.65%   +0.02%     
==========================================
  Files         219      219              
  Lines        6253     6265      +12     
==========================================
+ Hits         4917     4928      +11     
- Misses       1336     1337       +1     
Impacted Files Coverage Δ
...plementation/ZipkinActivityConversionExtensions.cs 92.23% <85.71%> (+0.15%) ⬆️
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 98.85% <100.00%> (+0.25%) ⬆️
....Jaeger/Implementation/JaegerActivityExtensions.cs 96.71% <100.00%> (+0.50%) ⬆️
src/OpenTelemetry/Internal/EnumerationHelper.cs 88.57% <0.00%> (-2.86%) ⬇️

@CodeBlanch CodeBlanch merged commit 1f04397 into open-telemetry:master Oct 4, 2020
@CodeBlanch CodeBlanch deleted the activity-enumerateeventsextension branch October 4, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants