Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change open census to OpenTelemetry in readme file + Update prometheus quick guide in readme #123

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Change open census to OpenTelemetry in readme file + Update prometheus quick guide in readme #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07433c8
Changed open census to OpenTelemetry in readme file
Jun 25, 2019
2f9e385
Added + wildcard, updated sample and readme to reflect sample
Jun 25, 2019
330753f
Merge branch 'master' into fix/122-fixreadme-opencensus-ref
SergeyKanzhelev Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ We encourage contributions. Use tags [up-for-grabs][up-for-grabs-issues] and

## OpenTelemetry QuickStart: collecting data

You can use Open Census API to instrument code and report data. Or use one of
You can use OpenTelemetry API to instrument code and report data. Or use one of
automatic data collection modules.

### Using ASP.NET Core incoming requests collector
Expand Down Expand Up @@ -199,7 +199,7 @@ Configure Prometheus exporter to have stats collected by Prometheus.
var exporter = new PrometheusExporter(
new PrometheusExporterOptions()
{
Url = new Uri("http://localhost:9184/metrics/")
Url = "http://+:9184/metrics/"
},
Stats.ViewManager);

Expand Down
2 changes: 1 addition & 1 deletion samples/Exporters/TestPrometheus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ internal static object Run()
var exporter = new PrometheusExporter(
new PrometheusExporterOptions()
{
Url = "http://localhost:9184/metrics/"
Url = "http://+:9184/metrics/" // "+" is a wildcard used to listen to all hostnames
},
Stats.ViewManager);

Expand Down