Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming ProbabilitySampler to TraceIdRatioBasedSampler #1174

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Renaming ProbabilitySampler to TraceIdRatioBasedSampler #1174

merged 4 commits into from
Aug 27, 2020

Conversation

eddynaka
Copy link
Contributor

Refs #1143

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team August 26, 2020 17:33
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #1174 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1174   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files         219      219           
  Lines        6261     6261           
=======================================
  Hits         4849     4849           
  Misses       1412     1412           
Impacted Files Coverage Δ
...rc/OpenTelemetry/Trace/TraceIdRatioBasedSampler.cs 89.47% <100.00%> (ø)

@cijothomas cijothomas merged commit 351c788 into open-telemetry:master Aug 27, 2020
@eddynaka eddynaka deleted the feature/renaming-probability-sampler branch August 27, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants