Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating VSTest nuget #1074

Merged
merged 8 commits into from
Aug 20, 2020
Merged

Updating VSTest nuget #1074

merged 8 commits into from
Aug 20, 2020

Conversation

eddynaka
Copy link
Contributor

Fixes #.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

cijothomas
cijothomas reviewed Aug 13, 2020
View reviewed changes
build/Common.props Outdated Show resolved Hide resolved
CodeBlanch
CodeBlanch approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddynaka
Copy link
Contributor Author

eddynaka commented Aug 15, 2020 •
edited
Loading

LGTM

dont merge please...we are waiting the new version to be released. I have updated to the new release. It is more reliable and stable

@CodeBlanch
Copy link
Member

@eddynaka 10-4

@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited
Loading

Codecov Report

Merging #1074 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   75.92%   75.94%   +0.01%     
==========================================
  Files         223      223              
  Lines        6381     6381              
==========================================
+ Hits         4845     4846       +1     
+ Misses       1536     1535       -1
Impacted Files Coverage Δ
...mentation.Http/HttpClientInstrumentationOptions.cs 100.00% <0.00%> (+4.16%) ⬆️

@eddynaka eddynaka marked this pull request as ready for review August 20, 2020 10:46
@eddynaka eddynaka requested a review from a team August 20, 2020 10:46
reyang
reyang approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodeBlanch CodeBlanch merged commit 4690783 into open-telemetry:master Aug 20, 2020
@eddynaka eddynaka deleted the test/updating-vstest-nuget branch August 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddynaka @CodeBlanch @cijothomas @reyang