Update console exporter #1051
Merged
Update console exporter #1051
+37
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Aug 12, 2020
| return builder.AddProcessor(new SimpleActivityProcessor(consoleExporter)); | ||
| var options = new ConsoleExporterOptions(); | ||
| configure?.Invoke(options); | ||
| return builder.AddProcessor(new SimpleActivityProcessor(new ConsoleExporter(options))); |
There was a problem hiding this comment.
Do we let user pick Simple vs Batched for other exporters?
There was a problem hiding this comment.
I guess it doesn't make much sense for console exporter to be batched as it is specifically designed for local dev scenario?
There was a problem hiding this comment.
Yea. I was asking general approach for other exporters which can operate in simple and batch mode..
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 77.13% 77.15% +0.01%
==========================================
Files 221 221
Lines 6092 6092
==========================================
+ Hits 4699 4700 +1
+ Misses 1393 1392 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1047, update the
ConsoleExporter.Changes
TagObjectsinstead ofTags, use precise timestamp format, improve readability).AddConsoleExporterfromUseConsoleExporterbased on discussion in Update MyExporter example #1047.Please provide a brief description of the changes here. Update the
CHANGELOG.mdfor non-trivial changes.For significant contributions please make sure you have completed the following items: