Pass the IServiceProvider in ConfigureResource, WithTracing & WithMetrics

[megla-tlanghorst]

Feature Request

Is your feature request related to a problem?

We need an IServiceProvider in ConfigureResource and WithTracing (and WithMetrics if we'd use it) for stuff like the options pattern.

Describe the solution you'd like:

A service provider being provided (as an option) to the respective callbacks.

Describe alternatives you've considered.

For ConfigureResource you could maybe get it done with an extension method, but you're basically rewriting library code at that point. For WithTracing I don't see a solution, without accessing private stuff via reflection.

Additional Context

[CodeBlanch]

Just for anyone landing on this issue see #4139 (comment) for some code you can use to accomplish these tasks today using the 1.4 API.

[antmeehan]

@cijothomas Can we please re-open this as #4261 doesn't appear to fix this issue (in the way #4228 attempted)?

[CodeBlanch]

We won't be adding top-level extensions which expose IServiceProvider for now because they are dangerous.

If you want to use IServiceProvider to do resource detection we support stuff like this:

appBuilder.Services.AddOpenTelemetry()
    .ConfigureResource(b => b.AddDetector(sp => new MyResourceDetector(sp)));

internal sealed class MyResourceDetector : IResourceDetector
{
    private readonly IServiceProvider serviceProvider;

    public MyResourceDetector(IServiceProvider serviceProvider)
    {
        this.serviceProvider = serviceProvider;
    }

    public Resource Detect()
    {
        var options = this.serviceProvider.GetRequiredService<IOptions<MyOptions>>().Value;

        Dictionary<string, object> values = new();

        if (options.AddSomeResourceInfo)
        {
            // add keys
        }

        if (options.AddSomeOtherResourceStuff)
        {
            // add keys
        }

        return new(values);
    }
}

If you want to access IServiceProvider to configure logging/tracing/metrics we have this shape:

services.AddOpenTelemetry().WithTracing();
services.ConfigureOpenTelemetryTracerProvider((sp, builder) => { 
   // Configure TracerProviderBuilder using IServiceProvider but watch out IServiceCollection is no longer available...
});

Do those work for your use case?

[antmeehan]

Thanks @CodeBlanch for the detailed response. I was actually already using ConfigureOpenTelemetryTracerProvider to add attributes which is working except they aren't being applied to log traces (it seems to only be applying the default server role etc). I'm observing the same behaviour using the AddDetector you've suggested so I'm guessing I'm doing something wrong on my side.