Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTLP/HTTP binary protobuf trace exporter for .NET #2292

Closed
rypdal opened this issue Aug 27, 2021 · 3 comments · Fixed by #2316
Closed

Add OTLP/HTTP binary protobuf trace exporter for .NET #2292

rypdal opened this issue Aug 27, 2021 · 3 comments · Fixed by #2316
Labels
enhancement New feature or request

Comments

@rypdal
Copy link
Contributor

rypdal commented Aug 27, 2021 •
edited
Loading

Is your feature request related to a problem?
According to the compliance matrix OTLP/HTTP binary protobuf trace exporter for .NET is not implemented.

Describe the solution you'd like:
Implement System.Net.Http.HttpClient based exporter.

Describe alternatives you've considered.

Additional Context
@rypdal rypdal added the enhancement New feature or request label Aug 27, 2021
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 3, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
7071ed5 
…2292 (open-telemetry#2292)

- HttpClient based Implementation
- unit tests for OtlpHttpTraceExporter
- added console test example using OtlpHttpTraceExporter
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 3, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
77cc454 
…2292

- unit test improvement
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 6, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
6a09c22 
…2292 (open-telemetry#2292)

- added helper for async from sync method calls
- made Send method of IHttpHandler synchronous
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 6, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
9d1471b 
…2292 (open-telemetry#2292)

- added NET 5.0 to list of target frameworks
- adapted HttpHandler.Send method implementation according to used target
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 7, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
34ef797 
…2292

- removed redundant IDisposable implementation for HttpHandler
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 7, 2021
@rypdal
Add OTLP/HTTP binary protobuf trace exporter for .NET open-telemetry#…
b06f415 
…2292

- proper variables naming
- code cleanup
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 24, 2021
@rypdal
open-telemetry#2292
ea93e71 
- removed usage of signal specific endpoints for Traces and Metrics (OTEL_EXPORTER_OTLP_TRACES_ENDPOINT, OTEL_EXPORTER_OTLP_METRICS_ENDPOINT) - it should be considered along with other signal specific env. variables in a scope of dedicated PR
- implemented according to Protocol specification rule for  appending of traces path (if not already present) in the OtlpHttpTraceExportClient class
- unit tests
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 27, 2021
@rypdal
open-telemetry#2292:
1285cca 
- Grpc.Net.Client should be used for net5.0 as well
- comments correction
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 27, 2021
@rypdal
open-telemetry#2292: got rod of HttpClient wrapper and adapted unit t…
e850df0 
…ests
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 28, 2021
@rypdal
open-telemetry#2292: removed trailing spaces (sanity check build)
53de69c
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 29, 2021
@rypdal
open-telemetry#2292: removed unused usings
33e98ca
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 30, 2021
@rypdal
open-telemetry#2292: empty line in project ignored by merge tools, bu…
517e0a6 
…t it causing encoding build check to fail
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Sep 30, 2021
@rypdal
open-telemetry#2292: prevent Api Compatibility run (see OpenTelemetry…
8855053 
….Exporter.Zipkin.csproj)
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Oct 4, 2021
@rypdal
open-telemetry#2292: renamed CancelExportRequest method to more appro…
a93a00a 
…priate Shutdown
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Oct 4, 2021
@rypdal
open-telemetry#2292: modified CHANGELOG, PublicAPI, README + prefixed…
ac4191c 
… ExportProtocol with Otlp (aligned with project naming)
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Oct 5, 2021
@rypdal
open-telemetry#2292: string type instead of enum for setting protocol…
0ed6523 
… in console test app.
rypdal added a commit to rypdal/opentelemetry-dotnet that referenced this issue Oct 5, 2021
@rypdal
open-telemetry#2292: fixed spelling and spacing
da8fe64
@z1c0
Copy link
Contributor

z1c0 commented Oct 21, 2021

This can be closed (fixed with #2316).

@pellared pellared mentioned this issue Oct 21, 2021
Merged
3 tasks
@pellared
Copy link
Member

Closing. There is a potential follow-up PR to address: #2316 (comment) but this issue is for sure solved. Nice work @rypdal 👏

@z1c0
Copy link
Contributor

z1c0 commented Oct 21, 2021

Nice work indeed @rypdal! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/2292 otlp http binary protobuf trace exporter rypdal/opentelemetry-dotnet
3 participants
@z1c0 @pellared @rypdal