Skip to content

Commit

Permalink
typo fixes (#3459)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kielek authored Jul 20, 2022
1 parent 5c9a5c6 commit d93606e
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid
/// Sets the maximum number of Metric streams supported by the MeterProvider.
/// When no Views are configured, every instrument will result in one metric stream,
/// so this control the numbers of instruments supported.
/// When Views are configued, a single instrument can result in multiple metric streams,
/// When Views are configured, a single instrument can result in multiple metric streams,
/// so this control the number of streams.
/// </summary>
/// <param name="meterProviderBuilder">MeterProviderBuilder instance.</param>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class OtlpExporterOptionsExtensionsTests : Http2UnencryptedSupportTests
[InlineData("key1 = value1, key2=value2 ", new string[] { "key1", "key2" }, new string[] { "value1", "value2" })]
[InlineData("key==value", new string[] { "key" }, new string[] { "=value" })]
[InlineData("access-token=abc=/123,timeout=1234", new string[] { "access-token", "timeout" }, new string[] { "abc=/123", "1234" })]
[InlineData("key1=value1;key2=value2", new string[] { "key1" }, new string[] { "value1;key2=value2" })] // semicolon is not treated as a delimeter (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#specifying-headers-via-environment-variables)
[InlineData("key1=value1;key2=value2", new string[] { "key1" }, new string[] { "value1;key2=value2" })] // semicolon is not treated as a delimiter (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#specifying-headers-via-environment-variables)
public void GetMetadataFromHeadersWorksCorrectFormat(string headers, string[] keys, string[] values)
{
var options = new OtlpExporterOptions
Expand Down Expand Up @@ -73,7 +73,7 @@ public void GetMetadataFromHeadersThrowsExceptionOnInvalidFormat(string headers)
[Theory]
[InlineData("")]
[InlineData(null)]
public void GetHeaders_NoOptionHeaders_ReturnsEmptyHeadres(string optionHeaders)
public void GetHeaders_NoOptionHeaders_ReturnsEmptyHeaders(string optionHeaders)
{
var options = new OtlpExporterOptions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests
public class OtlpLogExporterTests : Http2UnencryptedSupportTests
{
[Fact]
public void AddOtlpLogExporterOptionstest()
public void AddOtlpLogExporterOptionsTest()
{
AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport", true);
var loggerOptions = new OpenTelemetryLoggerOptions();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ public void ToOtlpSpanNativeActivityStatusTest(ActivityStatusCode expectedStatus
}

[Theory]
[InlineData(StatusCode.Unset, "Unset", "Description will be ingored if status is Unset.")]
[InlineData(StatusCode.Unset, "Unset", "Description will be ignored if status is Unset.")]
[InlineData(StatusCode.Ok, "Ok", "Description must only be used with the Error StatusCode.")]
[InlineData(StatusCode.Error, "Error", "Error description.")]
public void ToOtlpSpanStatusTagTest(StatusCode expectedStatusCode, string statusCodeTagValue, string statusDescription)
Expand Down
2 changes: 1 addition & 1 deletion test/OpenTelemetry.Tests/Shared/TestEventListener.cs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ protected override void OnEventWritten(EventWrittenEventArgs eventData)
/// <param name="eventSource">The event source that was created.</param>
protected override void OnEventSourceCreated(EventSource eventSource)
{
// Check for null because this method is called by the base class constror before we can initialize it
// Check for null because this method is called by the base class constructor before we can initialize it
Action<EventSource> callback = this.OnOnEventSourceCreated;
callback?.Invoke(eventSource);
}
Expand Down
16 changes: 8 additions & 8 deletions test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ public void SdkDoesNotProcessLegacyActivityWithNoAdditionalConfig()
(a) =>
{
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -476,7 +476,7 @@ public void SdkSamplesAndProcessesLegacyActivityWithRightConfig()
{
Assert.True(samplerCalled);
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -537,7 +537,7 @@ public void SdkSamplesAndProcessesLegacyActivityWithRightConfigOnWildCardMode()
{
Assert.True(samplerCalled);
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -586,7 +586,7 @@ public void SdkCallsOnlyProcessorOnStartForLegacyActivityWhenActivitySourceIsUpd
(a) =>
{
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -635,7 +635,7 @@ public void SdkProcessesLegacyActivityWhenActivitySourceIsUpdatedWithAddSource()
(a) =>
{
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -684,7 +684,7 @@ public void SdkProcessesLegacyActivityEvenAfterAddingNewProcessor()
(a) =>
{
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalled = true;
};

Expand Down Expand Up @@ -724,7 +724,7 @@ public void SdkProcessesLegacyActivityEvenAfterAddingNewProcessor()
(a) =>
{
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
startCalledNew = true;
};

Expand Down Expand Up @@ -1126,7 +1126,7 @@ public void SdkSamplesAndProcessesLegacySourceWhenAddLegacySourceIsCalledWithWil
{
Assert.Contains(a.OperationName, sampledActivities);
Assert.False(Sdk.SuppressInstrumentation);
Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true
Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true
onStartProcessedActivities.Add(a.OperationName);
};

Expand Down

0 comments on commit d93606e

Please sign in to comment.