Fix min/max snapshot for explicit bounds histogram (#4306)

open-telemetry · Mar 16, 2023 · d924663 · d924663
1 parent 3d6656f
commit d924663
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/src/OpenTelemetry.Exporter.InMemory/CHANGELOG.md b/src/OpenTelemetry.Exporter.InMemory/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Fixed issue where the `MetricSnapshot` of a histogram did not capture the min
+  and max values.
+  ([#4306](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4306))
+
 ## 1.5.0-alpha.1
 
 Released 2023-Mar-07

diff --git a/src/OpenTelemetry/Metrics/HistogramBuckets.cs b/src/OpenTelemetry/Metrics/HistogramBuckets.cs
@@ -87,6 +87,8 @@ internal HistogramBuckets Copy()
 
             Array.Copy(this.SnapshotBucketCounts, copy.SnapshotBucketCounts, this.SnapshotBucketCounts.Length);
             copy.SnapshotSum = this.SnapshotSum;
+            copy.SnapshotMin = this.SnapshotMin;
+            copy.SnapshotMax = this.SnapshotMax;
 
             return copy;
         }

diff --git a/test/OpenTelemetry.Tests/Metrics/MetricSnapshotTests.cs b/test/OpenTelemetry.Tests/Metrics/MetricSnapshotTests.cs
@@ -117,13 +117,19 @@ public void VerifySnapshot_Histogram()
             ref readonly var metricPoint1 = ref metricPoints1Enumerator.Current;
             Assert.Equal(1, metricPoint1.GetHistogramCount());
             Assert.Equal(10, metricPoint1.GetHistogramSum());
+            metricPoint1.TryGetHistogramMinMaxValues(out var min, out var max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
 
             // Verify Snapshot 1
             Assert.Single(exportedSnapshots);
             var snapshot1 = exportedSnapshots[0];
             Assert.Single(snapshot1.MetricPoints);
             Assert.Equal(1, snapshot1.MetricPoints[0].GetHistogramCount());
             Assert.Equal(10, snapshot1.MetricPoints[0].GetHistogramSum());
+            snapshot1.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
 
             // Verify Metric == Snapshot
             Assert.Equal(metric1.Name, snapshot1.Name);
@@ -141,6 +147,9 @@ public void VerifySnapshot_Histogram()
             // This value is expected to be updated.
             Assert.Equal(2, metricPoint1.GetHistogramCount());
             Assert.Equal(15, metricPoint1.GetHistogramSum());
+            metricPoint1.TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
 
             // Verify Metric 2
             Assert.Equal(2, exportedMetrics.Count);
@@ -150,18 +159,27 @@ public void VerifySnapshot_Histogram()
             ref readonly var metricPoint2 = ref metricPoints2Enumerator.Current;
             Assert.Equal(2, metricPoint2.GetHistogramCount());
             Assert.Equal(15, metricPoint2.GetHistogramSum());
+            metricPoint2.TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
 
             // Verify Snapshot 1 after second export
             // This value is expected to be unchanged.
             Assert.Equal(1, snapshot1.MetricPoints[0].GetHistogramCount());
             Assert.Equal(10, snapshot1.MetricPoints[0].GetHistogramSum());
+            snapshot1.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
 
             // Verify Snapshot 2
             Assert.Equal(2, exportedSnapshots.Count);
             var snapshot2 = exportedSnapshots[1];
             Assert.Single(snapshot2.MetricPoints);
             Assert.Equal(2, snapshot2.MetricPoints[0].GetHistogramCount());
             Assert.Equal(15, snapshot2.MetricPoints[0].GetHistogramSum());
+            snapshot2.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
         }
 
         [Fact]