[Instrumentation.SqlClient] Stop emitting db.statement_type attribute (…

…#5301) Co-authored-by: Vishwesh Bankwar <[email protected]>
open-telemetry · Feb 5, 2024 · a31bca8 · a31bca8
1 parent ef977c1
commit a31bca8
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md
@@ -11,6 +11,8 @@
 * **Breaking Change**: Renamed `SqlClientInstrumentationOptions` to
   `SqlClientTraceInstrumentationOptions`.
   ([#5285](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5285))
+* **Breaking Change**: Stop emitting `db.statement_type` attribute.
+  ([#5301](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5301))
 
 ## 1.6.0-beta.3
 

diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
@@ -108,7 +108,6 @@ public override void OnEventWritten(string name, object payload)
                             switch (commandType)
                             {
                                 case CommandType.StoredProcedure:
-                                    activity.SetTag(SpanAttributeConstants.DatabaseStatementTypeKey, nameof(CommandType.StoredProcedure));
                                     if (this.options.SetDbStatementForStoredProcedure)
                                     {
                                         activity.SetTag(SemanticConventions.AttributeDbStatement, (string)commandText);
@@ -117,7 +116,6 @@ public override void OnEventWritten(string name, object payload)
                                     break;
 
                                 case CommandType.Text:
-                                    activity.SetTag(SpanAttributeConstants.DatabaseStatementTypeKey, nameof(CommandType.Text));
                                     if (this.options.SetDbStatementForText)
                                     {
                                         activity.SetTag(SemanticConventions.AttributeDbStatement, (string)commandText);
@@ -126,7 +124,6 @@ public override void OnEventWritten(string name, object payload)
                                     break;
 
                                 case CommandType.TableDirect:
-                                    activity.SetTag(SpanAttributeConstants.DatabaseStatementTypeKey, nameof(CommandType.TableDirect));
                                     break;
                             }
                         }

diff --git a/src/Shared/SpanAttributeConstants.cs b/src/Shared/SpanAttributeConstants.cs
@@ -12,5 +12,4 @@ internal static class SpanAttributeConstants
 {
     public const string StatusCodeKey = "otel.status_code";
     public const string StatusDescriptionKey = "otel.status_description";
-    public const string DatabaseStatementTypeKey = "db.statement_type";
 }
diff --git a/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlEventSourceTests.netfx.cs b/test/OpenTelemetry.Instrumentation.SqlClient.Tests/SqlEventSourceTests.netfx.cs
@@ -246,8 +246,6 @@ private static void VerifyActivityData(
 
         Assert.Equal("master", activity.GetTagValue(SemanticConventions.AttributeDbName));
 
-        // "db.statement_type" is never set by the SqlEventSource instrumentation
-        Assert.Null(activity.GetTagValue(SpanAttributeConstants.DatabaseStatementTypeKey));
         if (captureText)
         {
             Assert.Equal(commandText, activity.GetTagValue(SemanticConventions.AttributeDbStatement));