resolve pr comments

open-telemetry · May 6, 2022 · 9257e9e · 9257e9e
1 parent d34da2b
commit 9257e9e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Added additional metric dimensions.
+  ([3247](https://github.com/open-telemetry/opentelemetry-dotnet/pull/3247))
+
 * Removes net5.0 target as .NET 5.0 is going out
   of support. The package keeps netstandard2.1 target, so it
   can still be used with .NET5.0 apps.

diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs b/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs
@@ -83,7 +83,7 @@ public override void OnStopActivity(Activity activity, object payload)
                     { SemanticConventions.AttributeHttpMethod, context.Request.Method },
                     { SemanticConventions.AttributeHttpHost, host },
                     { SemanticConventions.AttributeHttpTarget, target },
-                    { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode },
+                    { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode.ToString() },
                 };
             }
             else
@@ -94,7 +94,7 @@ public override void OnStopActivity(Activity activity, object payload)
                     { SemanticConventions.AttributeHttpScheme, context.Request.Scheme },
                     { SemanticConventions.AttributeHttpMethod, context.Request.Method },
                     { SemanticConventions.AttributeHttpHost, host },
-                    { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode },
+                    { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode.ToString() },
                 };
             }
 #else
@@ -104,7 +104,7 @@ public override void OnStopActivity(Activity activity, object payload)
                 { SemanticConventions.AttributeHttpScheme, context.Request.Scheme },
                 { SemanticConventions.AttributeHttpMethod, context.Request.Method },
                 { SemanticConventions.AttributeHttpHost, host },
-                { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode },
+                { SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode.ToString() },
             };
 
 #endif