Skip to content

Commit

Permalink
Learning to spell is a life-long process
Browse files Browse the repository at this point in the history
  • Loading branch information
alanwest committed Jan 13, 2021
1 parent 180640b commit 808ae2f
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@

<!--
There is an integration test for the OTLP exporter that runs a test targeting netcoreapp2.1, netcoreapp3.1 and net5.0.
The .NET Core 2.1 SDK cannot handle the presense of a netstandard2.1 target, so this project fails to build for the
The .NET Core 2.1 SDK cannot handle the presence of a netstandard2.1 target, so this project fails to build for the
netcoreapp2.1 test with the following error:
/usr/share/dotnet/sdk/2.1.811/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(150,5):
error NETSDK1045: The current .NET SDK does not support targeting .NET Standard 2.1.
Either target .NET Standard 2.0 or lower, or use a version of the .NET SDK that supports .NET Standard 2.1.
[/repo/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj]
When the CI runs the integration test, the TARGET_FRAMEWORK variable is set. The presense of this variable is used
When the CI runs the integration test, the TARGET_FRAMEWORK variable is set. The presence of this variable is used
to determine whether to include the netstandard2.1 target.
Ideally, this would check the version of the SDK used to build the project rather than a check that is dependent on
Expand Down

0 comments on commit 808ae2f

Please sign in to comment.