Fix tests to avoid external dependency (#2884)

open-telemetry · Feb 10, 2022 · 7826269 · 7826269
1 parent b1d57e9
commit 7826269
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs
@@ -354,7 +354,7 @@ public async Task HttpClientInstrumentationCorrelationAndBaggage()
                 .Build())
             {
                 using var c = new HttpClient();
-                using var r = await c.GetAsync("https://opentelemetry.io/").ConfigureAwait(false);
+                using var r = await c.GetAsync(this.url).ConfigureAwait(false);
             }
 
             Assert.Equal(5, activityProcessor.Invocations.Count);

diff --git a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.netcore31.cs b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.netcore31.cs
@@ -221,11 +221,11 @@ public async Task DebugIndividualTestAsync()
         [Fact]
         public async Task CheckEnrichmentWhenSampling()
         {
-            await CheckEnrichment(new AlwaysOffSampler(), 0).ConfigureAwait(false);
-            await CheckEnrichment(new AlwaysOnSampler(), 2).ConfigureAwait(false);
+            await CheckEnrichment(new AlwaysOffSampler(), 0, this.url).ConfigureAwait(false);
+            await CheckEnrichment(new AlwaysOnSampler(), 2, this.url).ConfigureAwait(false);
         }
 
-        private static async Task CheckEnrichment(Sampler sampler, int expect)
+        private static async Task CheckEnrichment(Sampler sampler, int expect, string url)
         {
             Counter = 0;
             var processor = new Mock<BaseProcessor<Activity>>();
@@ -236,7 +236,7 @@ private static async Task CheckEnrichment(Sampler sampler, int expect)
                 .Build())
             {
                 using var c = new HttpClient();
-                using var r = await c.GetAsync("https://opentelemetry.io/").ConfigureAwait(false);
+                using var r = await c.GetAsync(url).ConfigureAwait(false);
             }
 
             Assert.Equal(expect, Counter);