Test min/max

open-telemetry · Mar 15, 2023 · 4b85dae · 4b85dae
1 parent 2a86f96
commit 4b85dae
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/test/OpenTelemetry.Tests/Metrics/MetricSnapshotTests.cs b/test/OpenTelemetry.Tests/Metrics/MetricSnapshotTests.cs
@@ -193,6 +193,9 @@ public void VerifySnapshot_ExponentialHistogram()
             ref readonly var metricPoint1 = ref metricPoints1Enumerator.Current;
             Assert.Equal(1, metricPoint1.GetHistogramCount());
             Assert.Equal(10, metricPoint1.GetHistogramSum());
+            metricPoint1.TryGetHistogramMinMaxValues(out var min, out var max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
             AggregatorTest.AssertExponentialBucketsAreCorrect(expectedHistogram, metricPoint1.GetExponentialHistogramData());
 
             // Verify Snapshot 1
@@ -201,6 +204,9 @@ public void VerifySnapshot_ExponentialHistogram()
             Assert.Single(snapshot1.MetricPoints);
             Assert.Equal(1, snapshot1.MetricPoints[0].GetHistogramCount());
             Assert.Equal(10, snapshot1.MetricPoints[0].GetHistogramSum());
+            snapshot1.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
             AggregatorTest.AssertExponentialBucketsAreCorrect(expectedHistogram, snapshot1.MetricPoints[0].GetExponentialHistogramData());
 
             // Verify Metric == Snapshot
@@ -220,6 +226,9 @@ public void VerifySnapshot_ExponentialHistogram()
             // This value is expected to be updated.
             Assert.Equal(2, metricPoint1.GetHistogramCount());
             Assert.Equal(15, metricPoint1.GetHistogramSum());
+            metricPoint1.TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
 
             // Verify Metric 2
             Assert.Equal(2, exportedMetrics.Count);
@@ -229,19 +238,28 @@ public void VerifySnapshot_ExponentialHistogram()
             ref readonly var metricPoint2 = ref metricPoints2Enumerator.Current;
             Assert.Equal(2, metricPoint2.GetHistogramCount());
             Assert.Equal(15, metricPoint2.GetHistogramSum());
+            metricPoint1.TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
             AggregatorTest.AssertExponentialBucketsAreCorrect(expectedHistogram, metricPoint2.GetExponentialHistogramData());
 
             // Verify Snapshot 1 after second export
             // This value is expected to be unchanged.
             Assert.Equal(1, snapshot1.MetricPoints[0].GetHistogramCount());
             Assert.Equal(10, snapshot1.MetricPoints[0].GetHistogramSum());
+            snapshot1.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(10, min);
+            Assert.Equal(10, max);
 
             // Verify Snapshot 2
             Assert.Equal(2, exportedSnapshots.Count);
             var snapshot2 = exportedSnapshots[1];
             Assert.Single(snapshot2.MetricPoints);
             Assert.Equal(2, snapshot2.MetricPoints[0].GetHistogramCount());
             Assert.Equal(15, snapshot2.MetricPoints[0].GetHistogramSum());
+            snapshot2.MetricPoints[0].TryGetHistogramMinMaxValues(out min, out max);
+            Assert.Equal(5, min);
+            Assert.Equal(10, max);
             AggregatorTest.AssertExponentialBucketsAreCorrect(expectedHistogram, snapshot2.MetricPoints[0].GetExponentialHistogramData());
         }
     }