Fixed the unit test TracerSdkSetsActivitySamplingResultBasedOnSamplin…

…gDecision
open-telemetry · Jan 21, 2021 · 0f5491e · 0f5491e
1 parent 59fdea9
commit 0f5491e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs b/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs
@@ -162,8 +162,6 @@ public void TracerSdkSetsActivitySamplingResultBasedOnSamplingDecision()
 
             using (var activity = activitySource.StartActivity("root"))
             {
-                // Even if sampling returns false, for root activities,
-                // activity is still created with PropagationOnly.
                 Assert.NotNull(activity);
                 Assert.True(activity.IsAllDataRequested);
                 Assert.False(activity.Recorded);
@@ -176,17 +174,19 @@ public void TracerSdkSetsActivitySamplingResultBasedOnSamplingDecision()
 
             using (var activity = activitySource.StartActivity("root"))
             {
-                // Even if sampling returns false, for root activities,
+                // Even if sampling returns false,
                 // activity is still created with PropagationOnly.
                 Assert.NotNull(activity);
                 Assert.False(activity.IsAllDataRequested);
                 Assert.False(activity.Recorded);
 
                 using (var innerActivity = activitySource.StartActivity("inner"))
                 {
-                    // This is not a root activity.
-                    // If sampling returns false, no activity is created at all.
-                    Assert.Null(innerActivity);
+                    // If sampling returns false, activity is created with PropagationOnly regardless
+                    // of whether the activity is root or not.
+                    Assert.NotNull(activity);
+                    Assert.False(activity.IsAllDataRequested);
+                    Assert.False(activity.Recorded);
                 }
             }
         }