Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Testcontainers instead of DotNet.Testcontainers #856

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

pellared
Copy link
Member

@pellared pellared commented Jun 22, 2022

Why

DotNet.Testcontainers is now Testcontainers

Fixes #854

What

Use the latest Testcontainers 2.0.1 instead of DotNet.Testcontainers 1.6.0

Tests

CI

Checklist

  • [ ] CHANGELOG.md is updated.
  • [ ] Documentation is updated.
  • [ ] New features are covered by tests.

@pellared pellared requested a review from a team June 22, 2022 10:36
@pellared
Copy link
Member Author

pellared commented Jun 22, 2022

Failure caused by
testcontainers/testcontainers-dotnet#485

Error: [xUnit.net 00:00:12.65]     IntegrationTests.AspNet.AspNetTests.SubmitsTraces [FAIL]
  10:43:09 [ERR] [xUnit.net 00:00:12.65]     IntegrationTests.AspNet.AspNetTests.SubmitsTraces [FAIL]
  10:43:09 [DBG]   Failed IntegrationTests.AspNet.AspNetTests.SubmitsTraces [10 s]
  10:43:09 [DBG]   Error Message:
  10:43:09 [DBG]    System.AggregateException : One or more errors occurred.
  10:43:09 [DBG] ---- System.ArgumentNullException : Value cannot be null.
  10:43:09 [DBG] Parameter name: source
  10:43:09 [DBG]   Stack Trace:
  10:43:09 [DBG]      at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
  10:43:09 [DBG]    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
  10:43:09 [DBG]    at System.Threading.Tasks.Task.Wait(TimeSpan timeout)
  10:43:09 [DBG]    at IntegrationTests.Helpers.TestHelper.<StartContainerAsync>d__9.MoveNext() in D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\integration-tests\IntegrationTests.Helpers\TestHelper.cs:line 88
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG]    at IntegrationTests.AspNet.AspNetTests.<SubmitsTraces>d__2.MoveNext() in D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\integration-tests\aspnet\IntegrationTests.AspNet\AspNetTests.cs:line 29
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG] ----- Inner Stack Trace -----
  10:43:09 [DBG]    at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
  10:43:09 [DBG]    at DotNet.Testcontainers.Clients.TestcontainersConfigurationConverter.ToNetworks.<Convert>b__2_0(IDockerNetwork network)
  10:43:09 [DBG]    at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext()
  10:43:09 [DBG]    at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
  10:43:09 [DBG]    at DotNet.Testcontainers.Clients.TestcontainersConfigurationConverter..ctor(ITestcontainersConfiguration configuration)
  10:43:09 [DBG]    at DotNet.Testcontainers.Clients.DockerContainerOperations.<RunAsync>d__16.MoveNext()
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG]    at DotNet.Testcontainers.Clients.TestcontainersClient.<RunAsync>d__22.MoveNext()
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG]    at DotNet.Testcontainers.Containers.TestcontainersContainer.<Create>d__35.MoveNext()
  10:43:09 [DBG] --- End of stack trace from previous location where exception was thrown ---
  10:43:09 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  10:43:09 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  10:43:09 [DBG]    at DotNet.Testcontainers.Containers.TestcontainersContainer.<StartAsync>d__27.MoveNext()

@pellared
Copy link
Member Author

Bumping Testcontainers to 2.0.1 fixed the issue.

@rajkumar-rangaraj rajkumar-rangaraj merged commit 8e3920d into open-telemetry:main Jun 22, 2022
@pellared pellared deleted the bump-testcontainers branch June 22, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Testcontainers instead of DotNet.Testcontainers
2 participants