Rejit - Switch to shared pointer and apply same behavior for initial call #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
test-modules-default
branch
3 times, most recently
from
c063f79 to
b6020c8
Compare
|
Adding |
Kielek
force-pushed
the
test-modules-default
branch
6 times, most recently
from
3ad23c0 to
bceb673
Compare
Kielek
force-pushed
the
test-modules-default
branch
from
bceb673 to
d87c78b
Compare
Kielek
changed the title
pjanotti
approved these changes
Dec 12, 2024
RassK
approved these changes
Dec 12, 2024
zacharycmontoya
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #3838
Follow up: #2472
Mimic: DataDog/dd-trace-dotnet@3639f54
What
Brings changes from #2472 also to our initialization calls.
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.[ ] New features are covered by tests.Notes
At the time of writing notes 3/3 consecutive runs are green + couple more with non-polished version of this PR.