-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SqlClient metrics #3875
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/OpenTelemetry.AutoInstrumentation/Loading/Initializers/SqlClientMetricsInitializer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
using System.Reflection; | ||
using OpenTelemetry.AutoInstrumentation.Plugins; | ||
|
||
namespace OpenTelemetry.AutoInstrumentation.Loading.Initializers; | ||
|
||
internal sealed class SqlClientMetricsInitializer : SqlClientInitializer | ||
{ | ||
private readonly PluginManager _pluginManager; | ||
|
||
private int _initialized; | ||
|
||
public SqlClientMetricsInitializer(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager) | ||
: base(lazyInstrumentationLoader) | ||
{ | ||
_pluginManager = pluginManager; | ||
} | ||
|
||
protected override void InitializeOnFirstCall(ILifespanManager lifespanManager) | ||
{ | ||
if (Interlocked.Exchange(ref _initialized, value: 1) != default) | ||
{ | ||
// InitializeOnFirstCall() was already called before | ||
return; | ||
} | ||
|
||
var instrumentationType = Type.GetType("OpenTelemetry.Instrumentation.SqlClient.SqlClientInstrumentation, OpenTelemetry.Instrumentation.SqlClient")!; | ||
var instrumentation = instrumentationType.InvokeMember("AddMetricHandle", BindingFlags.InvokeMethod | BindingFlags.Public | BindingFlags.Static, Type.DefaultBinder, null, []); | ||
|
||
if (instrumentation != null) | ||
{ | ||
lifespanManager.Track(instrumentation); | ||
} | ||
} | ||
} |
50 changes: 50 additions & 0 deletions
50
src/OpenTelemetry.AutoInstrumentation/Loading/Initializers/SqlClientTracerInitializer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
using System.Reflection; | ||
using OpenTelemetry.AutoInstrumentation.Configurations; | ||
using OpenTelemetry.AutoInstrumentation.Plugins; | ||
|
||
namespace OpenTelemetry.AutoInstrumentation.Loading.Initializers; | ||
|
||
internal sealed class SqlClientTracerInitializer : SqlClientInitializer | ||
{ | ||
private readonly PluginManager _pluginManager; | ||
private readonly TracerSettings _tracerSettings; | ||
|
||
private int _initialized; | ||
|
||
public SqlClientTracerInitializer(LazyInstrumentationLoader lazyInstrumentationLoader, PluginManager pluginManager, TracerSettings tracerSettings) | ||
: base(lazyInstrumentationLoader) | ||
{ | ||
_pluginManager = pluginManager; | ||
_tracerSettings = tracerSettings; | ||
} | ||
|
||
protected override void InitializeOnFirstCall(ILifespanManager lifespanManager) | ||
{ | ||
if (Interlocked.Exchange(ref _initialized, value: 1) != default) | ||
{ | ||
// InitializeOnFirstCall() was already called before | ||
return; | ||
} | ||
|
||
var instrumentationType = Type.GetType("OpenTelemetry.Instrumentation.SqlClient.SqlClientInstrumentation, OpenTelemetry.Instrumentation.SqlClient")!; | ||
|
||
var options = new OpenTelemetry.Instrumentation.SqlClient.SqlClientTraceInstrumentationOptions | ||
{ | ||
SetDbStatementForText = _tracerSettings.InstrumentationOptions.SqlClientSetDbStatementForText | ||
}; | ||
_pluginManager.ConfigureTracesOptions(options); | ||
|
||
var propertyInfo = instrumentationType.GetProperty("TracingOptions", BindingFlags.Static | BindingFlags.Public); | ||
propertyInfo?.SetValue(null, options); | ||
|
||
var instrumentation = instrumentationType.InvokeMember("AddTracingHandle", BindingFlags.InvokeMethod | BindingFlags.Public | BindingFlags.Static, Type.DefaultBinder, null, []); | ||
|
||
if (instrumentation != null) | ||
{ | ||
lifespanManager.Track(instrumentation); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link leads to changelog, there is no good documentation for metrics yet.