Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-docs] document TypeAttributes.Serializable in DuckTyping #3840

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[code-docs] document TypeAttributes.Serializable in DuckTyping #3840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/OpenTelemetry.AutoInstrumentation/DuckTyping/DuckType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,9 @@ private static ModuleBuilder CreateTypeAndModuleBuilder(Type typeToDeriveFrom, T
parentType = typeof(ValueType);
typeAttributes = TypeAttributes.Public | TypeAttributes.AnsiClass | TypeAttributes.BeforeFieldInit | TypeAttributes.SequentialLayout | TypeAttributes.Sealed
#pragma warning disable SYSLIB0050
// TODO verify how to handle TypeAttributes.Serializable which is obsolete.
// It was working fine with binaries compiled against .NET6 executed in .NET8 runtime.
// TypeAttributes.Serializable is obsolete. There is a recommendation to keep code as is.
// to mitigate potential unknown issues.
// Historically, t was working fine with binaries compiled against .NET6 executed in .NET8 runtime.
// https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/3799
| TypeAttributes.Serializable;
#pragma warning restore SYSLIB0050
Expand Down
Loading