Bump lang version to 10.0 #375
Conversation
which i 10.0 right now
|
Consider to disable whitespace diff when you are checking diff. |
| @@ -6,108 +6,107 @@ | |||
| using OpenTelemetry.Exporter; | |||
| using Xunit; | |||
|
|
|||
| namespace OpenTelemetry.AutoInstrumentation.Tests.Configuration | |||
| namespace OpenTelemetry.AutoInstrumentation.Tests.Configuration; | |||
There was a problem hiding this comment.
How about reformatting the whole codebase for sake of consistency?
Maybe it is only me, but I favor consistency when I am reading code. Even when new features reduces some noise. 😄
There was a problem hiding this comment.
Sure, I can do it, in this PR?
There was a problem hiding this comment.
As for me. YES 👍 Especially that there are no open PRs touching the code.
And it would be good to merge on timely manner to reduce possible conflicts.
|
Guys.
Possible solutions
Do you have any preferences? |
Can you check how they solved it as they should also support .NET 4.6.1? |
|
The issue is related to using For most cases, I was able to fix it, the only leftover is https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/tree/main/test/test-applications/integrations/dependency-libs . Previous comment is still valid. We can bump environment to
|
|
But everything works for fine I created a separate issue where we can discuss .NET Framework 4.6.1 support #376 |
|
@pellared, yes, IMO it is ready to be merged. Some improvements can be done later. |
test/test-applications/integrations/dependency-libs/Directory.Build.props
Show resolved
Hide resolved
#351 leftovers
Changes proposed in this pull request:
Bump supported lang version to the latest (10.0).
10.0 version is also used in .NET OTel SDK repo.
When the previous PR was created there were not support for .NET 6/Lang 10 in our pipeline.