Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka] do not use message creation context as a parent for consumer spans #3438

Merged
merged 6 commits into from
May 29, 2024

Conversation

lachmatt
Copy link
Contributor

@lachmatt lachmatt commented May 28, 2024

Why

Fixes #3434

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@lachmatt lachmatt requested a review from a team May 28, 2024 07:49
@github-actions github-actions bot requested a review from theletterf May 28, 2024 08:00
@RassK
Copy link
Contributor

RassK commented May 29, 2024

@lachmatt do you have any images how does it look like?

I'm a bit confused about this description. To me it seems there should be 2 spans? receive (that includes polling time) that is linked to consume span? or receive = consume?
open-telemetry/opentelemetry-demo#1538 (comment)

@lachmatt
Copy link
Contributor Author

@lachmatt do you have any images how does it look like?

I'm a bit confused about this description. To me it seems there should be 2 spans? receive (that includes polling time) that is linked to consume span? or receive = consume? open-telemetry/opentelemetry-demo#1538 (comment)

Receive is type of consumer span/operation. Consume is the name of the method being instrumented.
There will be single span on consumer side, with link to the propagated context.

@RassK
Copy link
Contributor

RassK commented May 29, 2024

@lachmatt ah right, so the linked propagated context is actually kafka publish?

@Kielek Kielek merged commit c38843a into open-telemetry:main May 29, 2024
42 checks passed
@lachmatt lachmatt deleted the kafka-instrumentation-adjustment branch May 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kafka] do not use the message creation context as a parent for receive spans by default
3 participants