Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.0 #3387

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Release 1.6.0 #3387

merged 6 commits into from
Apr 29, 2024

Conversation

lachmatt
Copy link
Contributor

@lachmatt lachmatt commented Apr 25, 2024

Why & What

Release 1.6.0

Changed

  • To prevent sensitive information from leaking through query strings, the
    following instrumentations redact by default any value detected in query string
    components when building the url.query or the url.full attributes:
    OpenTelemetry.Instrumentation.Http, OpenTelemetry.Instrumentation.AspNetCore,
    OpenTelemetry.Instrumentation.AspNet. For example, ?key1=value1&key2=value2
    becomes ?key1=Redacted&key2=Redacted. You can customize this behavior through
    the environment variables. See the
    instrumentation options table for details.

Dependency updates

  • Following packages updated
    • OpenTelemetry.Instrumentation.Http from 1.8.0 to 1.8.1.
  • .NET only, following packages updated
    • Microsoft.Extensions.Configuration.Binder from 8.0.0 to 8.0.1,
    • OpenTelemetry.Instrumentation.AspNetCore from 1.8.0 to 1.8.1.
  • .NET Framework only, following packages updated
    • OpenTelemetry.Instrumentation.AspNet from 1.8.0-beta.1 to 1.8.0-beta.2.

Fixed

  • Stop creating receive consumer spans for consume attempts that returned no message.
    For details, see #3367

Tests

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@lachmatt lachmatt requested a review from a team April 25, 2024 08:51
@github-actions github-actions bot requested a review from theletterf April 25, 2024 08:51
@pellared
Copy link
Member

Can bump to 1.6.0 to indicate changes and new env vars?

@pellared
Copy link
Member

Tests passed on macOS

@Kielek
Copy link
Contributor

Kielek commented Apr 25, 2024

Can bump to 1.6.0 to indicate changes and new env vars?

Yesterday, we have agreed that it should go as 1.5.1. Nothing change since this discussion.

@lachmatt
Copy link
Contributor Author

Tests passed on Windows with Linux containers.

@pellared
Copy link
Member

pellared commented Apr 25, 2024

Yesterday, we have agreed that it should go as 1.5.1. Nothing change since this discussion.

Sorry but I was distracted at this moment.

I think it can be frustrating for some users. I feel it is safer to make a minor bump.

What is wrong with making a minor bump?

@pellared
Copy link
Member

For reference https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/versioning.md#minor-version-bump:

Minor version bump
Most changes result in a minor version bump.

  • Addition of new functionality, configuration, or instrumentation library.
    Changes related to the instrumentation libraries:
  • Change (can be breaking) in a supported instrumentation library's functionality or configuration.

Releasing it as a patch bump would break our versioning policy.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a minor bump according to our versioning policy

@lachmatt lachmatt changed the title Release 1.5.1 Release 1.6.0 Apr 26, 2024
@lachmatt
Copy link
Contributor Author

This needs to be a minor bump according to our versioning policy

Changed to 1.6.0

@Kielek Kielek merged commit 10b2464 into open-telemetry:main Apr 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants