Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define supported Kafka versions #3316

Merged
merged 14 commits into from
Mar 26, 2024
Merged

Conversation

RassK
Copy link
Contributor

@RassK RassK commented Mar 12, 2024

Why

Fixes #3306

What

  • Makes LibraryVersion partial (logic + generated definitions)
  • Can generate different versions for different platforms (x64 vs ARM64).
  • Fixes Kafka tests to support other versions
  • Adds Kafka supported range for ARM64 (docs)

Tests

Existing.

Tests do not work with versions 1.8.0-1.8.1 on ARM64. I'm not sure if it's because of the OS version or the range itself is broken.

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@github-actions github-actions bot requested a review from theletterf March 14, 2024 10:50
@RassK RassK marked this pull request as ready for review March 14, 2024 12:23
@RassK RassK requested a review from a team March 14, 2024 12:23
docs/config.md Outdated Show resolved Hide resolved
@Kielek Kielek enabled auto-merge (squash) March 26, 2024 17:07
@Kielek Kielek merged commit dca75ff into open-telemetry:main Mar 26, 2024
41 checks passed
@RassK RassK deleted the kafka-versions branch March 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redefine supported Kafka ranges
3 participants