Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry.distro.name and telemetry.distro.version #3006

Merged
merged 1 commit into from
Oct 12, 2023
Merged

telemetry.distro.name and telemetry.distro.version #3006

merged 1 commit into from
Oct 12, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 12, 2023

Why

Fixes #2993 and the new sem. conv. version is released https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.22.0

What

From sem-conv:

**[1]:** Official auto instrumentation agents and distributions SHOULD set the `telemetry.distro.name` attribute to
a string starting with `opentelemetry-`, e.g. `opentelemetry-java-instrumentation`.

Tests

CI

Checklist

  • CHANGELOG.md is updated.
  • [ ] Documentation is updated.
  • New features are covered by tests.

@Kielek Kielek requested a review from a team October 12, 2023 18:59
@rajkumar-rangaraj rajkumar-rangaraj merged commit 220f331 into open-telemetry:main Oct 12, 2023
28 checks passed
@Kielek Kielek deleted the telemetry-distro-attributes branch October 12, 2023 20:46
@Kielek Kielek mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telemetry.distro.name and telemetry.distro.version
3 participants
@Kielek @rajkumar-rangaraj @zacharycmontoya