Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xunit from 2.5.0 to 2.5.1 #2963

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Bump xunit from 2.5.0 to 2.5.1 #2963

merged 3 commits into from
Sep 18, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 18, 2023

Bumps xunit from 2.5.0 to 2.5.1.

Commits
  • 9dc851b v2.5.1
  • 86b0eef #2770: Make SerializationHelper public
  • f49dafc File re-sort for SerializationHelper & XunitSerializationInfo
  • d0004ae #2773: Add Assert.RaisesAny and Assert.RaisesAnyAsync non-generic for EventAr...
  • c1dba28 Latest assertions
  • b7c828e Move .editorconfig up into contentFiles
  • 08e74e7 Add .editorconfig to assert source NuGet package to indicate generated code (...
  • 79f411a #2767: Verify types match when comparing FileSystemInfo values (v2)
  • 9c28f58 Latest dependencies
  • 63dce4f #2767: Special case FileSystemInfo objects by just comparing the FullName in ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [xunit](https://github.com/xunit/xunit) from 2.5.0 to 2.5.1.
- [Commits](xunit/xunit@2.5.0...2.5.1)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team September 18, 2023 12:22
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies labels Sep 18, 2023
@Kielek Kielek enabled auto-merge (squash) September 18, 2023 12:30
@pjanotti
Copy link
Contributor

pjanotti commented Sep 18, 2023

We need to fix

  12:48:06 [INF] > "C:\Program Files\dotnet\dotnet.exe" build D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj --configuration Release
  12:48:06 [DBG] MSBuild version 17.7.1+971bf70db for .NET
  12:48:07 [DBG]   Determining projects to restore...
  12:48:09 [DBG]   Restored D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj (in 1.09 sec).
  12:48:09 [DBG]   2 of 3 projects are up-to-date for restore.
  12:48:10 [DBG]   SourceGenerators -> D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\src\SourceGenerators\bin\Release\netstandard2.0\SourceGenerators.dll
  12:48:11 [DBG]   OpenTelemetry.AutoInstrumentation -> D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation\bin\Release\net6.0\OpenTelemetry.AutoInstrumentation.dll
  Error: D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\LogTests.cs(86,52): error xUnit1030: Test methods should not call ConfigureAwait(), as it may bypass parallelization limits. (https://xunit.net/xunit.analyzers/rules/xUnit1030) [D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj::TargetFramework=net6.0]
  12:48:13 [ERR] D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\LogTests.cs(86,52): error xUnit1030: Test methods should not call ConfigureAwait(), as it may bypass parallelization limits. (https://xunit.net/xunit.analyzers/rules/xUnit1030) [D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj::TargetFramework=net6.0]
  12:48:14 [DBG]   OpenTelemetry.AutoInstrumentation -> D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation\bin\Release\net462\OpenTelemetry.AutoInstrumentation.dll
  Error: D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\LogTests.cs(86,52): error xUnit1030: Test methods should not call ConfigureAwait(), as it may bypass parallelization limits. (https://xunit.net/xunit.analyzers/rules/xUnit1030) [D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj::TargetFramework=net7.0]
  12:48:16 [ERR] D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\LogTests.cs(86,52): error xUnit1030: Test methods should not call ConfigureAwait(), as it may bypass parallelization limits. (https://xunit.net/xunit.analyzers/rules/xUnit1030) [D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\IntegrationTests.csproj::TargetFramework=net7.0]
  12:48:20 [DBG]   IntegrationTests -> D:\a\opentelemetry-dotnet-instrumentation\opentelemetry-dotnet-instrumentation\test\IntegrationTests\bin\Release\net462\IntegrationTests.dll
  12:48:20 [DBG] 
  12:48:20 [DBG] Build FAILED.

Test methods should not call ConfigureAwait(), as it may bypass parallelization limits.
@pjanotti
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 18, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Kielek Kielek merged commit 31caff1 into main Sep 18, 2023
27 checks passed
@Kielek Kielek deleted the dependabot/nuget/xunit-2.5.1 branch September 18, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants