Fix S.D.DS version rule on .NET 7.0 #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
approved these changes
Sep 14, 2023
rajkumar-rangaraj
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix #2950
What
Per SIG conversation:
Removed the rule checking directly for S.D.DS version and added S.D.DS version validation to the rule checking versions of other libraries directly referenced by the entry assembly. The rule in question was renamed to
AssemblyFileVersionChecksince now it is not covering only instrumentation libraries.Tests
Manually validated that the new rule is working as intended against .NET 7.0.
Checklist
CHANGELOG.mdis updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.