Disable optional rules by default on the NuGet package scripts #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
reviewed
Sep 14, 2023
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuleEngine.cs
Outdated
Show resolved
Hide resolved
…opentelemetry-dotnet-instrumentation into nuget-disable-rules-by-default
nrcventura
reviewed
Sep 15, 2023
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuleEngine.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Sep 15, 2023
nrcventura
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What these rules validate can't happen when using the NuGet.
What
Set
OTEL_DOTNET_AUTO_RULE_ENGINE_ENABLEDtofalseon the script shipped by the NuGet package.Tests
Locally run StartupHook.Tests to validate cea5e15
Checklist
- [ ]CHANGELOG.mdis updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.