Skip more assemblies by their prefix #2841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 CI failures on mac 1 on Alpine: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/5863049402/job/15903137724?pr=2841 🤔 |
|
The failures are consistent. I need to investigate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Reduce the amount of work done on the
CorProfilerBase::GetAssemblyReferencescallback.Collateral of #2833
What
Assemblies that are not going to be instrumented don't need to be internally tracked. This generates a lot of noise on debug logs and waste work on normal operations. Besides
OpenTelemetryprefix I'm also adding some also from the current upstream: https://github.com/DataDog/dd-trace-dotnet/blob/5292fc6b09b29e924e62eb6c1cb82107b43d4789/tracer/src/Datadog.Tracer.Native/debugger_constants.h#L16There are more differences with upstream, but, since we are close to GA let's be careful with these changes, so, at least for now not adding
MicrosoftorSystemto skip prefixes.Tests
N/A
Checklist
- [ ]CHANGELOG.mdis updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.