Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0-rc.2 #2795

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Aug 2, 2023

Why & What

Release 1.0.0-rc.2
Drop support for Azure SDK on .NET Framework (see failing test details below in discussion).

Tests

  • CI
  • MacOS with Linux Containers
  • Windows with Linux Containers (after excluding Azure SDK on .NET Framework)

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • [ ] New features are covered by tests.

@Kielek Kielek requested a review from a team August 2, 2023 16:26
@pellared
Copy link
Member

pellared commented Aug 2, 2023

nuke Workflow passed on macOS

@Kielek
Copy link
Contributor Author

Kielek commented Aug 2, 2023

Windows nuke Workflow with linux subsytem status.

Almost everything passed. Exceptions for .NET Framework

[ERR] RunManagedIntegratio: [xUnit.net 00:08:27.11] IntegrationTests.DomainNeutralTests.SubmitsTraces [FAIL] - passed after rerun.

Following are constantly failing (it is not part of CI, there is no possibility to configure GH machines in this way).

[ERR] RunManagedIntegratio: [xUnit.net 00:05:38.90]     IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.17.0") [FAIL]
[ERR] RunManagedIntegratio: [xUnit.net 00:06:42.16]     IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.13.0") [FAIL]

@rajkumar-rangaraj agreed to verify root cause of this blocking issue.

CHANGELOG.md Show resolved Hide resolved
@pellared
Copy link
Member

pellared commented Aug 2, 2023

Adding more output for the test failure from my machine

19:55:22 [ERR] [xUnit.net 00:00:59.25]     IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.17.0") [FAIL]
19:55:22 [ERR] [xUnit.net 00:00:59.26]     IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.13.0") [FAIL]
19:55:23 [DBG]   Failed IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.17.0") [1 ms]
19:55:23 [DBG]   Error Message:
19:55:23 [DBG]    Docker.DotNet.DockerApiException : Docker API responded with status code=InternalServerError, response={"message":"driver failed programming external connectivity on endpoint azure-storage-54324 (befba1179e06ddf0249edff67a2abab3ae2ed3b7d259379b8c56fde65d983f60): listen tcp4 0.0.0.0:54324: bind: address already in use"}
19:55:23 [DBG]
19:55:23 [DBG]   Stack Trace:
19:55:23 [DBG]      at Docker.DotNet.DockerClient.<HandleIfErrorResponseAsync>d__67.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at Docker.DotNet.DockerClient.<MakeRequestAsync>d__55.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at Docker.DotNet.ContainerOperations.<StartContainerAsync>d__16.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Clients.TestcontainersClient.<StartAsync>d__28.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Containers.DockerContainer.<UnsafeStartAsync>d__61.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Containers.DockerContainer.<StartAsync>d__49.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at IntegrationTests.AzureFixture.<LaunchAzureContainerAsync>d__9.MoveNext() in C:\Users\rpajak\repos\opentelemetry-dotnet-instrumentation\test\IntegrationTests\AzureCollection.cs:line 69
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at IntegrationTests.AzureFixture.<InitializeAsync>d__7.MoveNext() in C:\Users\rpajak\repos\opentelemetry-dotnet-instrumentation\test\IntegrationTests\AzureCollection.cs:line 47
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]   Failed IntegrationTests.AzureTests.SubmitsTraces(packageVersion: "12.13.0") [1 ms]
19:55:23 [DBG]   Error Message:
19:55:23 [DBG]    Docker.DotNet.DockerApiException : Docker API responded with status code=InternalServerError, response={"message":"driver failed programming external connectivity on endpoint azure-storage-54324 (befba1179e06ddf0249edff67a2abab3ae2ed3b7d259379b8c56fde65d983f60): listen tcp4 0.0.0.0:54324: bind: address already in use"}
19:55:23 [DBG]
19:55:23 [DBG]   Stack Trace:
19:55:23 [DBG]      at Docker.DotNet.DockerClient.<HandleIfErrorResponseAsync>d__67.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at Docker.DotNet.DockerClient.<MakeRequestAsync>d__55.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at Docker.DotNet.ContainerOperations.<StartContainerAsync>d__16.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Clients.TestcontainersClient.<StartAsync>d__28.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Containers.DockerContainer.<UnsafeStartAsync>d__61.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at DotNet.Testcontainers.Containers.DockerContainer.<StartAsync>d__49.MoveNext()
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at IntegrationTests.AzureFixture.<LaunchAzureContainerAsync>d__9.MoveNext() in C:\Users\rpajak\repos\opentelemetry-dotnet-instrumentation\test\IntegrationTests\AzureCollection.cs:line 69
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
19:55:23 [DBG]    at IntegrationTests.AzureFixture.<InitializeAsync>d__7.MoveNext() in C:\Users\rpajak\repos\opentelemetry-dotnet-instrumentation\test\IntegrationTests\AzureCollection.cs:line 47
19:55:23 [DBG] --- End of stack trace from previous location where exception was thrown ---
19:55:23 [DBG]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
19:55:23 [DBG]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

@pjanotti
Copy link
Contributor

pjanotti commented Aug 2, 2023

🤔

[ERR] RunManagedIntegratio: [xUnit.net 00:08:27.11] IntegrationTests.DomainNeutralTests.SubmitsTraces [FAIL] - passed after rerun.

Locally or in CI? This test is not flaky IIRC, let me know if you have detailed error messages.

@Kielek
Copy link
Contributor Author

Kielek commented Aug 3, 2023

🤔

[ERR] RunManagedIntegratio: [xUnit.net 00:08:27.11] IntegrationTests.DomainNeutralTests.SubmitsTraces [FAIL] - passed after rerun.

Locally or in CI? This test is not flaky IIRC, let me know if you have detailed error messages.

Locally. I do not have any details saved.

@Kielek
Copy link
Contributor Author

Kielek commented Aug 3, 2023

As agreed yesterday with @rajkumar-rangaraj , I am dropping support to Azure SDK on .NET Framework. We can bring it back in next release.

@Kielek Kielek added this to the 1.0.0-rc.2 milestone Aug 3, 2023
@Kielek Kielek merged commit 2f5e1fc into open-telemetry:main Aug 3, 2023
27 checks passed
@Kielek Kielek deleted the otel-dotnet-1.0.0-rc.2 branch August 3, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants