Sdk diagnostic listener EventLevel based on configured LogLevel #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachmatt
commented
Mar 22, 2023
| LogLevel.Debug => EventLevel.Verbose, | ||
| LogLevel.Error => EventLevel.Error, | ||
| LogLevel.Warning => EventLevel.Warning, | ||
| LogLevel.Information => EventLevel.Informational, |
There was a problem hiding this comment.
this is a default log level - I'm wondering if EventLevel.Informational might be little too verbose. LMK if you think I should change it e.g EventLevel.Warning
There was a problem hiding this comment.
I would rather consider changing the levels of event logs produced by the SDK instead.
Kielek
approved these changes
Mar 22, 2023
pellared
reviewed
Mar 23, 2023
.../OpenTelemetry.AutoInstrumentation.Tests/Diagnostics/SdkSelfDiagnosticsEventListenerTests.cs
Outdated
Show resolved
Hide resolved
pellared
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #959
What
Set
EventLevelforSdkSelfDiagnosticsEventListenerbased on configured log level.Tests
Updated in PR.
Checklist
- [ ]CHANGELOG.mdis updated.- [ ] Documentation is updated.