Automatic netfx assembly redirection #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e291eb8. We need some extra work to automate this process and also a friendly way to register assemblies in the GAC.
pjanotti
force-pushed
the
net-fx-auto-redirect
branch
from
5c2e20a to
f6fb7c7
Compare
Kielek
reviewed
Dec 16, 2022
src/OpenTelemetry.AutoInstrumentation.Native/netfx_assembly_redirection.h
Outdated
Show resolved
Hide resolved
2nd round with changelog text
|
I'm having second thoughts about having a static list of versions: we could look at startup for the assemblies shipped with the app to update the version of the redirection. Anyway, I would prefer to address that in a separate PR. |
…-instrumentation into net-fx-auto-redirect
Kielek
approved these changes
Dec 20, 2022
I suppose that it will increase cold start time. Additional measurements are needed. |
…-instrumentation into net-fx-auto-redirect
Kielek
approved these changes
Dec 21, 2022
RassK
approved these changes
Dec 21, 2022
theletterf
suggested changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To automate instrumentation of .NET Framework without requiring binding redirection and reducing the cases that adding dependencies to the projects are needed.
Fixes #1646
What
netfxfolder and use it to generate a map of redirections to be used by the native profiler in_WIN32compilation.netfx.The risk is that dependencies are changed at runtime and it is possible that issues only show up when certain code paths are executed. A much safer path would be to have the application reference a NuGet package with all the dependencies required by automatic instrumentation.
To minimize the risk of downgrading packages used by the application, details here, we need the work from #1824 and #1823.
Tests
Checklist
CHANGELOG.mdis updated.