Support for .NET 7 #1617
Merged
Support for .NET 7 #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
commented
Nov 15, 2022
| @@ -129,7 +131,7 @@ partial class Build | |||
|
|
|||
| DotNetMSBuild(x => x | |||
There was a problem hiding this comment.
DotNetMSBuild is build in the Nuke itself, so I was able to remove our custom class.
| .SetConfiguration(BuildConfiguration) | ||
| .SetTargetPlatform(Platform) | ||
| .SetPlatform(Platform) |
There was a problem hiding this comment.
There is no way to pass Platform (x64/x86) through the dotnet tests to dotnet msbuild executed under the hood.
I have decided to call it directly.
This property is important, because .NET 7 SDK changed the output path structure based on this. Previously it was working only by accident.
| @@ -30,6 +30,7 @@ This component adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.h | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Add support for .NET 7. | |||
There was a problem hiding this comment.
The plan was only to add tests for .NET 7, but additional dependencies/store requires separate folder structure for each supported .NET version.
pellared
approved these changes
Nov 15, 2022
RassK
reviewed
Nov 15, 2022
RassK
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1537
What
Support for .NET 7.
Tests execution for .NET 7.
Fixes for
ILoggerbytecode instrumentation.Tests
Checklist
CHANGELOG.mdis updated.[ ] Documentation is updated.Newfeatures are covered by tests.