Log error if missing bytecode instrumentation method #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-instrumentation into log-error-if-missing-instrumentation-method
Kielek
reviewed
Oct 31, 2022
Kielek
approved these changes
Nov 2, 2022
theletterf
approved these changes
Nov 2, 2022
pellared
approved these changes
Nov 2, 2022
| @@ -2494,14 +2494,47 @@ HRESULT CorProfiler::CallTarget_RewriterCallback(RejitHandlerModule* moduleHandl | |||
| &wrapper_type_def); | |||
| if (FAILED(hr) || wrapper_type_def == mdTypeDefNil) | |||
| { | |||
| Logger::Warn("*** CallTarget_RewriterCallback() Failed for: ", caller->type.name, ".", caller->name, | |||
| Logger::Error("*** CallTarget_RewriterCallback() Failed for: ", caller->type.name, ".", caller->name, | |||
There was a problem hiding this comment.
Should it not be a warning? It is an oddity, but the application and instrumentation would continue to work without any bad side-effects. Should the user react when he notices such an error?
Maybe we should even "accept" such behavior so that we could use e.g. #if NETFRAMEWORK on a whole instrumentation class? Then we could even change this level to debug.
Leaving it for a discussion + potentially separate PR.
|
|
||
| if (!found_wrapper_method) | ||
| { | ||
| Logger::Error("*** CallTarget_RewriterCallback() Failed for: ", caller->type.name, ".", caller->name, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the bytecode instrumentation type doesn't have any of the expected instrumentation methods the bytecode instrumentation is injected during ReJIT but since there are no instrumentation methods it has no practical effect and no error/warning message is logged in any of the logs.
Fixes #1499
What
Tests
Checklist
CHANGELOG.mdis updated.- [] Documentation is updated.