Stabilize PrometheusExporter test #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
approved these changes
Sep 21, 2022
|
The failure fixed by this PR seems to be the most common for this test, but, there is also a failure mode in which no output is captured from the exporter, e.g.: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3100295202/jobs/5020411194#step:4:3382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It looks like there is some bug in PrometheusExporter: open-telemetry/opentelemetry-dotnet#3679
I think we should not test the SDK. I find that the test is "overspecified".
Fixes #1123
Still, we should explore what is/was going on...
What
Assert that any metric is exported.
Tests
CI
Checklist
CHANGELOG.mdis updated.Documentation is updated.New features are covered by tests.