Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix StrongNameTests #1257

Closed

Conversation

RassK
Copy link
Contributor

@RassK RassK commented Sep 21, 2022

What

Tries to fix the StrongNameTests by adding some time to exit.

Tests

Existing.

@RassK RassK force-pushed the experimental/strong-name-test-fix branch from 4ded1c7 to 8f2303b Compare September 21, 2022 15:53
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please also add similar changes to Program.cs for the DomainNeutralTests? Although it is not failing (afaik) it seems reasonable for it to also be a "LONG_RUNNING" one too.

@pjanotti
Copy link
Contributor

@RassK in light of #1242 (comment) I don't think this will solve the issue.

@RassK
Copy link
Contributor Author

RassK commented Sep 22, 2022

@RassK in light of #1242 (comment) I don't think this will solve the issue.

Yep, after I saw 0 received, then I already thought, probably not gonna solve.

@RassK RassK closed this Sep 22, 2022
@RassK RassK deleted the experimental/strong-name-test-fix branch November 3, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants