Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize SmokeTests.PrometheusExporter #1000

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 27, 2022

Why

(hopefully) Fixes #978

What

Lower the HTTP Client so that the test takes shorter time and retries the HTTP request.

Tests

CI

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@pellared pellared requested a review from a team July 27, 2022 09:40
@nrcventura
Copy link
Member

In the issue description, you mention the adding of a retry mechanism. Is that at the test level? Or is the intention for that to be at the request level?

@pellared
Copy link
Member Author

In the issue description, you mention the adding of a retry mechanism. Is that at the test level? Or is the intention for that to be at the request level?

At the test level:

await assert.Should().NotThrowAfterAsync(
waitTime: 30.Seconds(),
pollInterval: 1.Seconds());

@pellared pellared enabled auto-merge (squash) July 27, 2022 18:31
@pellared pellared merged commit 376e83b into open-telemetry:main Jul 27, 2022
@pellared pellared deleted the stabilize-PrometheusExporter branch July 27, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants