-
Notifications
You must be signed in to change notification settings - Fork 91
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes to support W3C style IDs and propagation (dotnet/corefx#33207)
* First set of changes to support W3C style IDs and propagation see https://w3c.github.io/trace-context This is mostly for discussion purposes. * Changed UseW3CFormat to be DefaultIdFormat * Review feedback * More comments. Small Renames * Added Sampling Support, Review feedback. * Added placeholder for SetRecordingDesired * Separated out the Sampling support into its own PR. * Remove more sampling support * Fix IsWC3Id -> IdFormat * Added Sampling Support, Review feedback. * Separated out the Sampling support into its own PR. * Add ForceW3C option. * Introduce ForceDefaultIdFormat * Adding SpanId and TraceId support * Change ulong->long in SpanID (probably temporary) * Remove undesired file changes * Fix up reference assembly. Note complete because of questions about Span<byte>, but closer now. * Turn on code that used Span<byte> * Defer setting IDFormat until start. This insures that the IDFormat property is either unknown or a given value (that never changes from there). * More implementation, made the interface more uniform. * Support to avoid using strings whenever possible Basically Id, SpanId TraceId properties are set lazily and only converted lazily. * Added some tests * First round of testing (and bugfixes) * More testing * Added Equality operators * Rename SpanId -> ActivitySpanId TraceId ->ActivityTraceId * Add Comments * Fix bad XML comment * Review feedback * Change AsBytes -> CopyTo Lifetime issues prevent returning Span<T> (which is what AsBytes does. Reverting to CopyTo instead. Also added System.Memory ref in attempt to resolve build errors (that don't reproduce locally). * Attempt to fix build break in netfx build * Deal with Verification errors. * Provide full namespace for SecuritySafeCriticalAttribute * More securitySafeCritical annotations to fix test failures on desktop * Another attempt on setting SecuritySafeCritical * Remove the readonly ref (to avoid perf issue) * Fix most -buildAllConfigurations issues * Tentative change to see if testing works if we ignore the older netstandard configs. * Workaround package cycle involving DiagnosticSource and Memory * Satisfy dangling System.Memory dangling reference in package tests * Add notes to remove the workarounds when Unsafe is fixed. * Review feedback Uses Utf8 helpers where possible. Commit migrated from dotnet/corefx@fa07e4f
- Loading branch information
Showing
7 changed files
with
1,019 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.